Re: [PATCH] netfilter: flowtable: fix tcp and udp header checksum update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sven,

On Tue, Feb 02, 2021 at 06:01:16PM +0100, sven.auhagen@xxxxxxxxxxxx wrote:
> From: Sven Auhagen <sven.auhagen@xxxxxxxxxxxx>
> 
> When updating the tcp or udp header checksum on port nat
> the function inet_proto_csum_replace2 with the last parameter
> pseudohdr as true.
> This leads to an error in the case that GRO is used and packets
> are split up in GSO.
> The tcp or udp checksum of all packets is incorrect.
> 
> The error is probably masked due to the fact the most network driver
> implement tcp/udp checksum offloading.
> It also only happens when GRO is applied and not on single packets.
> 
> The error is most visible when using a pppoe connection which is not
> triggering the tcp/udp checksum offload.

Good catch.

I'll apply this patch to nf.git.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux