Phil Sutter <phil@xxxxxx> wrote:
> > switch (nftnl_trace_get_u32(nlt, NFTNL_TRACE_TYPE)) {
> > case NFT_TRACETYPE_RULE:
> > verdict = nftnl_trace_get_u32(nlt, NFTNL_TRACE_VERDICT);
> > - printf(":rule:0x%llx:", (unsigned long long)nftnl_trace_get_u64(nlt, NFTNL_TRACE_RULE_HANDLE));
>
> Quite long long line here. ;)
> How about using PRIx64 in the format string to avoid the cast?
Its just being moved from here...
> > - print_verdict(nlt, verdict);
> >
> > - if (nftnl_trace_is_set(nlt, NFTNL_TRACE_RULE_HANDLE))
> > - trace_print_rule(nlt, arg);
> > if (nftnl_trace_is_set(nlt, NFTNL_TRACE_LL_HEADER) ||
> > nftnl_trace_is_set(nlt, NFTNL_TRACE_NETWORK_HEADER))
> > trace_print_packet(nlt, arg);
> > +
> > + if (nftnl_trace_is_set(nlt, NFTNL_TRACE_RULE_HANDLE)) {
> > + trace_print_hdr(nlt);
> > + printf(":rule:0x%llx:", (unsigned long long)nftnl_trace_get_u64(nlt, NFTNL_TRACE_RULE_HANDLE));
To this location. But sure, I can change it.
