Re: [PATCH nf] netfilter: nf_tables: avoid false-postive lockdep splat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 19, 2020 at 04:34:54PM +0100, Florian Westphal wrote:
> There are reports wrt lockdep splat in nftables, e.g.:
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 31416 at net/netfilter/nf_tables_api.c:622
> lockdep_nfnl_nft_mutex_not_held+0x28/0x38 [nf_tables]
> ...
> 
> These are caused by an earlier, unrelated bug such as a n ABBA deadlock
> in a different subsystem.
> In such an event, lockdep is disabled and lockdep_is_held returns true
> unconditionally.  This then causes the WARN() in nf_tables.
> 
> Make the WARN conditional on lockdep still active to avoid this.

Applied, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux