Jeremy Sowden <jeremy@xxxxxxxxxx> wrote: > > - | MAXSEG { $$ = TCPOPTHDR_MAXSEG; } > > + | MSS { $$ = TCPOPTHDR_MAXSEG; } > > + | SACK_PERM { $$ = TCPOPTHDR_SACK_PERMITTED; } > > | WINDOW { $$ = TCPOPTHDR_WINDOW; } > > - | SACK_PERMITTED { $$ = TCPOPTHDR_SACK_PERMITTED; } > > + | WSCALE { $$ = TCPOPTHDR_WINDOW; } > > Did you mean to add this here? Right, this could be a distinct change. ATM there is ... synproxy ... wscale and ... tcp option window ... Like the sack-perm vs. sack-permitted mess it probably makes sense to get rid of one of those tokens so both work interchangeably, i.e. tcp option wscale and tcp option window are the same. I will remove this chunk before pushing it out.