Since pknlusr is now installed, here are some improvements. There's one automake change related to the new man-page, a number of new patches tidying up the source of pknlusr.c, before a new version of the patch to remove the hard-coded group ID. The last four patches do a bit of tiding of the pknock kernel module. Jeremy Sowden (13): pknock: pknlusr: ensure man-page is included by `make dist`. pknock: pknlusr: remove dest_addr and rename src_addr. pknock: pknlusr: tighten up variable scopes. pknock: pknlusr: tidy up initialization of local address. pknock: pknlusr: use NLMSG macros and proper types, rather than arithmetic on char pointers. pknock: pknlusr: use macro to define inet_ntop buffer size. pknock: pknlusr: don't treat recv return value of zero as an error. pknock: pknlusr: always close socket. pknock: pknlusr: fix hard-coded netlink multicast group ID. pknock: xt_pknock: use IS_ENABLED. pknock: xt_pknock: use kzalloc. pknock: xt_pknock: use pr_err. pknock: xt_pknock: remove DEBUG definition. extensions/pknock/Makefile.am | 2 +- extensions/pknock/pknlusr.c | 120 ++++++++++++++++++++++------------ extensions/pknock/xt_pknock.c | 27 +++----- extensions/pknock/xt_pknock.h | 2 - 4 files changed, 88 insertions(+), 63 deletions(-) -- 2.28.0