On Thursday 2020-10-22 19:30, Jeremy Sowden wrote:
>The group ID used by xt_pknock is configurable, but pknlusr hard-codes
>it to 1. Modify pknlusr to accept an optional ID from the command-line.
According to netlink(7), that is not a group ID but a bitmask of groups.
That changes the semantic quite significantly and would make this patch faulty.
>+ n = strtol(argv[1], &end, 10);
>+ if (*end || n < INT_MIN || n > INT_MAX) {
>+ usage(argv[0]);
>+ exit(EXIT_FAILURE);
>+ }
It's a u32. It can never be less than 0, but it can very well be more than
INT_MAX.
