On Fri, Oct 09, 2020 at 03:03:35PM +0800, Ye Bin wrote: > Fix follow warning: > [net/netfilter/nf_nat_sip.c:469]: (warning) %u in format string (no. 1) > requires 'unsigned int' but the argument type is 'int'. Yes, but mangle_packet() takes unsigned int as buflen. This needs a bit wider look that, I'm afraid, a robot cannot afford. Thanks for submitting your patch in any case. > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx> > --- > net/netfilter/nf_nat_sip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c > index f0a735e86851..39754fb3a298 100644 > --- a/net/netfilter/nf_nat_sip.c > +++ b/net/netfilter/nf_nat_sip.c > @@ -466,7 +466,7 @@ static int mangle_content_len(struct sk_buff *skb, unsigned int protoff, > &matchoff, &matchlen) <= 0) > return 0; > > - buflen = sprintf(buffer, "%u", c_len); > + buflen = sprintf(buffer, "%d", c_len); > return mangle_packet(skb, protoff, dataoff, dptr, datalen, > matchoff, matchlen, buffer, buflen); > } > -- > 2.16.2.dirty >
