On Tue, Oct 06, 2020 at 01:41:21AM +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 23, 2020 at 12:53:41AM +0200, Phil Sutter wrote: > > The newly introduced ordered insert algorithm in > > xtables_register_{match,target}() works best if extensions of same name > > are passed in ascending revisions. Since this is the case in about all > > extensions' arrays, iterate over them from beginning to end. > > This patch should come first in the series, my understanding is that > 1/3 assumes that extensions are registered from lower to higher > revision number. No, the algorithm is supposed to work with arbitrary input. This is merely an optimization given how extension arrays are typically ordered. Cheers, Phil