Re: [PATCH nf] netfilter: ctnetlink: fix mark based dump filtering regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 01, 2020 at 08:56:19AM +0200, Martin Willi wrote:
> conntrack mark based dump filtering may falsely skip entries if a mask
> is given: If the mask-based check does not filter out the entry, the
> else-if check is always true and compares the mark without considering
> the mask. The if/else-if logic seems wrong.
> 
> Given that the mask during filter setup is implicitly set to 0xffffffff
> if not specified explicitly, the mark filtering flags seem to just
> complicate things. Restore the previously used approach by always
> matching against a zero mask is no filter mark is given.

Applied, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux