On Sat, 29 Aug 2020 13:18:50 +0200
Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Sat, Aug 29, 2020 at 09:04:05AM +0200, Balazs Scheidler wrote:
> > Signed-off-by: Balazs Scheidler <bazsi77@xxxxxxxxx>
> > ---
> > tests/monitor/run-tests.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/monitor/run-tests.sh b/tests/monitor/run-tests.sh
> > index ffb833a7..5a736fc6 100755
> > --- a/tests/monitor/run-tests.sh
> > +++ b/tests/monitor/run-tests.sh
> > @@ -1,7 +1,7 @@
> > #!/bin/bash
> >
> > cd $(dirname $0)
> > -nft=../../src/nft
> > +nft=${NFT:-../../src/nft}
> > debug=false
> > test_json=false
>
> IIRC, Stefano mentioned this might break valgrind due to lack of
> quotes?
Wait, this is just for monitor/run-tests.sh now. The problem was on the
change proposed for shell/run_tests.sh, which wasn't needed because
it already supports passing a different command, and is not in this
version.
For monitor/run-tests.sh, I think that will need some fixing anyway (if
we want to support wrappers at all). So this change itself just
improves things.
--
Stefano
