Re: [PATCH nf-next] netfilter: nft_socket: add wildcard support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nft_socket-add-wildcard-support/20200828-234531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: powerpc-randconfig-r004-20200828 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c10e63677f5d20f18010f8f68c631ddc97546f7d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> net/netfilter/nft_socket.c:26:43: error: no member named 'skc_v6_rcv_saddr' in 'struct sock_common'; did you mean 'skc_rcv_saddr'?
                   nft_reg_store8(dest, ipv6_addr_any(&sk->sk_v6_rcv_saddr));
                                                           ^
   include/net/sock.h:381:37: note: expanded from macro 'sk_v6_rcv_saddr'
   #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
                                       ^
   include/net/sock.h:170:11: note: 'skc_rcv_saddr' declared here
                           __be32  skc_rcv_saddr;
                                   ^
   1 error generated.

# https://github.com/0day-ci/linux/commit/b52e11e3bbfc9394df5d97f507e2f3cd66b58687
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nft_socket-add-wildcard-support/20200828-234531
git checkout b52e11e3bbfc9394df5d97f507e2f3cd66b58687
vim +26 net/netfilter/nft_socket.c

    16	
    17	static void nft_socket_wildcard(const struct nft_pktinfo *pkt,
    18					struct nft_regs *regs, struct sock *sk,
    19					u32 *dest)
    20	{
    21		switch (nft_pf(pkt)) {
    22		case NFPROTO_IPV4:
    23			nft_reg_store8(dest, inet_sk(sk)->inet_rcv_saddr == 0);
    24			break;
    25		case NFPROTO_IPV6:
  > 26			nft_reg_store8(dest, ipv6_addr_any(&sk->sk_v6_rcv_saddr));
    27			break;
    28		default:
    29			regs->verdict.code = NFT_BREAK;
    30			return;
    31		}
    32	}
    33	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux