On Wed, Aug 26, 2020 at 12:52:41AM +0200, Florian Westphal wrote: > With recent addition of clash resolution the 'insert_failed' counter has > become confusing. Depending on wheter clash resolution is successful, > insert_failed increments or both insert_failed and drop increment. > > Example (conntrack -S): > [..] insert_failed=15 drop=0 [..] search_restart=268 > > This means clash resolution worked and the insert_failed increase is harmeless. > In case drop is non-zero, things become murky. > > It would be better to have a dedicated counter that only increments when > clash resolution is successful. > > This series revisits conntrack statistics. Counters that do not > indicate an error or reside in fast-paths are removed. > > With patched kernel and conntrack tool, output looks similar to this > during a 'clash resolve' stress test: > > [..] insert_failed=9 drop=9 [..] search_restart=123 clash_resolve=3675 Series applied, thanks.
