Re: [nft PATCH] nft: rearrange help output to group related options together

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Jul 2020 at 12:43, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
>
> Hi Arturo,
>
> On Thu, Jul 23, 2020 at 12:38:09PM +0200, Arturo Borrero Gonzalez wrote:
> [...]
> > After this patch, the help output is:
> >
> > === 8< ===
> > % nft --help
> > Usage: nft [ options ] [ cmds... ]
> >
> > Options (general):
> >   -h, help                      Show this help
> >   -v, version                   Show version information
> >   -V                            Show extended version information
> >
> > Options (with operative meaning):
> >   -c, check                     Check commands validity without actually applying the changes.
> >   -f, file <filename>           Read input from <filename>
> >   -i, interactive               Read input from interactive CLI
> >   -I, includepath <directory>   Add <directory> to the paths searched for include files. Defaul[..]
> >
> > Options (output text modifiers for data translation):
> >
> >   -N, reversedns                Translate IP addresses to names.
> >   -S, service                   Translate ports to service names as described in /etc/services.
> >   -u, guid                      Print UID/GID as defined in /etc/passwd and /etc/group.
> >   -n, numeric                   Print fully numerical output.
> >   -y, numeric-priority          Print chain priority numerically.
> >   -p, numeric-protocol          Print layer 4 protocols numerically.
> >   -T, numeric-time              Print time values numerically.
> >
> > Options (output text modifiers for parsing and other operations):
> >   -d, debug <level [,level...]> Specify debugging level (scanner, parser, eval, netlink, mnl, p[..]
> >   -e, echo                      Echo what has been added, inserted or replaced.
> >   -s, stateless                 Omit stateful information of ruleset.
> >   -a, handle                    Output rule handle.
> >   -j, json                      Format output in JSON
> >   -t, terse                     Omit contents of sets.
> > === 8< ===
>
> My proposal:
>
> % nft --help
> Usage: nft [ options ] [ cmds... ]
>
> Options (general):
>   -h, help                      Show this help
>   -v, version                   Show version information
>   -V                            Show extended version information
>
> Options (ruleset input handling):
>   -f, file <filename>           Read input from <filename>
>   -i, interactive               Read input from interactive CLI
>   -I, includepath <directory>   Add <directory> to the paths searched for include files. Defaul[..]
>   -c, check                     Check commands validity without actually applying the changes.
>
> Options (ruleset list formatting):
>   -a, handle                    Output rule handle.
>   -s, stateless                 Omit stateful information of ruleset.
>   -t, terse                     Omit contents of sets.
>   -S, service                   Translate ports to service names as described in /etc/services.
>   -N, reversedns                Translate IP addresses to names.
>   -u, guid                      Print UID/GID as defined in /etc/passwd and /etc/group.
>   -n, numeric                   Print fully numerical output.
>   -y, numeric-priority          Print chain priority numerically.
>   -p, numeric-protocol          Print layer 4 protocols numerically.
>   -T, numeric-time              Print time values numerically.
>
> Options (command output format):
>   -e, echo                      Echo what has been added, inserted or replaced.
>   -j, json                      Format output in JSON
>   -d, debug <level [,level...]> Specify debugging level (scanner, parser, eval, netlink, mnl, p[..]

That's OK.

I'm AFK, could you please amend and push the patch?

regards.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux