On Fri, Jul 17, 2020 at 12:12:10PM +0200, Giuseppe Scrivano wrote: > Hi Pablo, > > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> writes: > > > Probably remove the check for lock_file[0] == '\0' > > > > Or is this intentional? > > I've added it intentionally as I think it is safer to ignore an empty > string. The programs I've checked, GNU coreutils and GNU grep, have the > same check. Thanks for explaining. > The empty string will likely fail on open(2), at least on tmpfs > it does with ENOENT. If you want though, I can drop the check. No worries, patch description did not explain this and quick git grep on iptables was showing no check for \0 in other spots in the tree. No need to drop the check.
