[nf-next:master 2/3] net/netfilter/ipvs/ip_vs_conn.c:1394:6: sparse: sparse: context imbalance in 'ip_vs_expire_nodest_conn_flush' - wrong count at exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
head:   3354c27699652b271b78c85f275b818e6b9843e6
commit: 04231e52d3557475231abe8a8fa1be0330826ed6 [2/3] ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: mips-randconfig-s032-20200715 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-49-g707c5017-dirty
        git checkout 04231e52d3557475231abe8a8fa1be0330826ed6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> net/netfilter/ipvs/ip_vs_conn.c:1394:6: sparse: sparse: context imbalance in 'ip_vs_expire_nodest_conn_flush' - wrong count at exit

# https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=04231e52d3557475231abe8a8fa1be0330826ed6
git remote add nf-next https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
git remote update nf-next
git checkout 04231e52d3557475231abe8a8fa1be0330826ed6
vim +/ip_vs_expire_nodest_conn_flush +1394 net/netfilter/ipvs/ip_vs_conn.c

04231e52d355747 Andrew Sy Kim 2020-07-08  1392  
04231e52d355747 Andrew Sy Kim 2020-07-08  1393  #ifdef CONFIG_SYSCTL
04231e52d355747 Andrew Sy Kim 2020-07-08 @1394  void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs)
04231e52d355747 Andrew Sy Kim 2020-07-08  1395  {
04231e52d355747 Andrew Sy Kim 2020-07-08  1396  	int idx;
04231e52d355747 Andrew Sy Kim 2020-07-08  1397  	struct ip_vs_conn *cp, *cp_c;
04231e52d355747 Andrew Sy Kim 2020-07-08  1398  	struct ip_vs_dest *dest;
04231e52d355747 Andrew Sy Kim 2020-07-08  1399  
04231e52d355747 Andrew Sy Kim 2020-07-08  1400  	rcu_read_lock();
04231e52d355747 Andrew Sy Kim 2020-07-08  1401  	for (idx = 0; idx < ip_vs_conn_tab_size; idx++) {
04231e52d355747 Andrew Sy Kim 2020-07-08  1402  		hlist_for_each_entry_rcu(cp, &ip_vs_conn_tab[idx], c_list) {
04231e52d355747 Andrew Sy Kim 2020-07-08  1403  			if (cp->ipvs != ipvs)
04231e52d355747 Andrew Sy Kim 2020-07-08  1404  				continue;
04231e52d355747 Andrew Sy Kim 2020-07-08  1405  
04231e52d355747 Andrew Sy Kim 2020-07-08  1406  			dest = cp->dest;
04231e52d355747 Andrew Sy Kim 2020-07-08  1407  			if (!dest || (dest->flags & IP_VS_DEST_F_AVAILABLE))
04231e52d355747 Andrew Sy Kim 2020-07-08  1408  				continue;
04231e52d355747 Andrew Sy Kim 2020-07-08  1409  
04231e52d355747 Andrew Sy Kim 2020-07-08  1410  			if (atomic_read(&cp->n_control))
04231e52d355747 Andrew Sy Kim 2020-07-08  1411  				continue;
04231e52d355747 Andrew Sy Kim 2020-07-08  1412  
04231e52d355747 Andrew Sy Kim 2020-07-08  1413  			cp_c = cp->control;
04231e52d355747 Andrew Sy Kim 2020-07-08  1414  			IP_VS_DBG(4, "del connection\n");
04231e52d355747 Andrew Sy Kim 2020-07-08  1415  			ip_vs_conn_del(cp);
04231e52d355747 Andrew Sy Kim 2020-07-08  1416  			if (cp_c && !atomic_read(&cp_c->n_control)) {
04231e52d355747 Andrew Sy Kim 2020-07-08  1417  				IP_VS_DBG(4, "del controlling connection\n");
04231e52d355747 Andrew Sy Kim 2020-07-08  1418  				ip_vs_conn_del(cp_c);
04231e52d355747 Andrew Sy Kim 2020-07-08  1419  			}
04231e52d355747 Andrew Sy Kim 2020-07-08  1420  		}
04231e52d355747 Andrew Sy Kim 2020-07-08  1421  		cond_resched_rcu();
04231e52d355747 Andrew Sy Kim 2020-07-08  1422  
04231e52d355747 Andrew Sy Kim 2020-07-08  1423  		/* netns clean up started, abort delayed work */
04231e52d355747 Andrew Sy Kim 2020-07-08  1424  		if (!ipvs->enable)
04231e52d355747 Andrew Sy Kim 2020-07-08  1425  			return;
04231e52d355747 Andrew Sy Kim 2020-07-08  1426  	}
04231e52d355747 Andrew Sy Kim 2020-07-08  1427  	rcu_read_unlock();
04231e52d355747 Andrew Sy Kim 2020-07-08  1428  }
04231e52d355747 Andrew Sy Kim 2020-07-08  1429  #endif
04231e52d355747 Andrew Sy Kim 2020-07-08  1430  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux