Hi Rob, Thank you for the patch! Yet something to improve: [auto build test ERROR on nf-next/master] [also build test ERROR on nf/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Rob-Gill/netfilter-Add-MODULE_DESCRIPTION-entries-to-kernel-modules/20200620-161928 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: um-allmodconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=um If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] In file included from include/linux/kernel.h:11, from net/netfilter/nft_reject_inet.c:6: include/asm-generic/fixmap.h: In function 'fix_to_virt': include/asm-generic/fixmap.h:32:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 32 | BUILD_BUG_ON(idx >= __end_of_fixed_addresses); | ^~ include/linux/compiler.h:330:9: note: in definition of macro '__compiletime_assert' 330 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ include/asm-generic/fixmap.h:32:2: note: in expansion of macro 'BUILD_BUG_ON' 32 | BUILD_BUG_ON(idx >= __end_of_fixed_addresses); | ^~~~~~~~~~~~ In file included from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:34, from include/linux/huge_mm.h:8, from include/linux/mm.h:679, from include/linux/bvec.h:13, from include/linux/skbuff.h:17, from include/linux/netlink.h:7, from net/netfilter/nft_reject_inet.c:9: arch/um/include/asm/uaccess.h: In function '__access_ok': arch/um/include/asm/uaccess.h:17:29: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 17 | (((unsigned long) (addr) >= FIXADDR_USER_START) && \ | ^~ arch/um/include/asm/uaccess.h:45:3: note: in expansion of macro '__access_ok_vsyscall' 45 | __access_ok_vsyscall(addr, size) || | ^~~~~~~~~~~~~~~~~~~~ net/netfilter/nft_reject_inet.c: At top level: >> net/netfilter/nft_reject_inet.c:152: error: unterminated argument list invoking macro "MODULE_DESCRIPTION" 152 | MODULE_DESCRIPTION("Netfilter nf_tables reject inet support" | >> net/netfilter/nft_reject_inet.c:152:1: error: expected '=', ',', ';', 'asm' or '__attribute__' at end of input 152 | MODULE_DESCRIPTION("Netfilter nf_tables reject inet support" | ^~~~~~~~~~~~~~~~~~ vim +/MODULE_DESCRIPTION +152 net/netfilter/nft_reject_inet.c 148 149 MODULE_LICENSE("GPL"); 150 MODULE_AUTHOR("Patrick McHardy <kaber@xxxxxxxxx>"); 151 MODULE_ALIAS_NFT_AF_EXPR(1, "reject"); > 152 MODULE_DESCRIPTION("Netfilter nf_tables reject inet support" --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip