Re: [PATCH nf-next] nft_set_pipapo: Drop useless assignment of scratch map index on insert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 14, 2020 at 11:42:07PM +0200, Stefano Brivio wrote:
> In nft_pipapo_insert(), we need to reallocate scratch maps that will
> be used for matching by lookup functions, if they have never been
> allocated or if the bucket size changes as a result of the insertion.
> 
> As pipapo_realloc_scratch() provides a pair of fresh, zeroed out
> maps, there's no need to select a particular one after reallocation.
> 
> Other than being useless, the existing assignment was also troubled
> by the fact that the index was set only on the CPU performing the
> actual insertion, as spotted by Florian.
> 
> Simply drop the assignment.

I have just refreshed nf-next to pull in your fix dependency.

Please, rebase and resubmit this patch on top of nf-next.

Thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux