Re: [iptables PATCH] xtables-translate: don't fail if help was requested

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arturo,

On Tue, Jun 16, 2020 at 11:33:39AM +0200, Arturo Borrero Gonzalez wrote:
> If the user called `iptables-translate -h` then we have CMD_NONE and we should gracefully handle
> this case in do_command_xlate().
> 
> Before this patch, you would see:
> 
>  user@debian:~$ sudo iptables-translate -h
>  [..]
>  nft Unsupported command?
>  user@debian:~$ echo $?
>  1
> 
> After this patch:
> 
>  user@debian:~$ sudo iptables-translate -h
>  [..]
>  user@debian:~$ echo $?
>  0

Apparently I forgot to test xtables-restore after changing help
functions, thanks for fixing this up.

> Fixes: d4409d449c10fa ("nft: Don't exit early after printing help texts")
> Signed-off-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx>

Acked-by: Phil Sutter <phil@xxxxxx>

Thanks, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux