On Mon, Jun 15, 2020 at 05:34:39AM -0700, Matthew Wilcox wrote: > On Mon, Jun 15, 2020 at 02:12:49PM +0200, Christoph Hellwig wrote: > > We still need to check if the fѕ is open write, even for the low-level > > helper. > > Do we need the analogous check for FMODE_READ in the __kernel_read() > patch? Yes, we should probably grow it. Hoping that none of the caller actually wants to mess with files not open for reading as some of them are rather dodgy.