Re: [PATCH nft,v2] evaluate: missing datatype definition in implicit_set_declaration()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun,  7 Jun 2020 15:40:07 +0200
Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:

> set->data from implicit_set_declaration(), otherwise, set_evaluation()
> bails out with:
> 
>  # nft -f /etc/nftables/inet-filter.nft
>  /etc/nftables/inet-filter.nft:8:32-54: Error: map definition does not specify
>  mapping data type
>                 tcp dport vmap { 22 : jump ssh_input }
>                                ^^^^^^^^^^^^^^^^^^^^^^^
>  /etc/nftables/inet-filter.nft:13:26-52: Error: map definition does not specify
>  mapping data type
>                  iif vmap { "eth0" : jump wan_input }
>                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Add a test to cover this case.
> 
> Fixes: 7aa08d45031e ("evaluate: Perform set evaluation on implicitly declared (anonymous) sets")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=208093
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Whoops, sorry, I didn't think of that case at all. Thanks for fixing it.

Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>

-- 
Stefano




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux