On Thu, 2020-05-28 at 12:44 -0700, Matthew Wilcox wrote: > On Thu, May 28, 2020 at 08:33:40PM +0100, Al Viro wrote: > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > > > Hard limits at 80 really don't work well, especially with > > > some of the 25+ character length identifiers used today. > > > > IMO any such identifier is a good reason for a warning. > > > > The litmus test is actually very simple: how unpleasant would it be > > to mention the identifiers while discussing the code over the phone? > > Here's a good example of a function which should be taken out and shot: > > int amdgpu_atombios_get_leakage_vddc_based_on_leakage_params(struct amdgpu_devic > e *adev, Ick. Seems simple enough as it doesn't appear to be used... $ git grep amdgpu_atombios_get_leakage_vddc_based_on_leakage_params drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:int amdgpu_atombios_get_leakage_vddc_based_on_leakage_params(struct amdgpu_device *adev, drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h:int amdgpu_atombios_get_leakage_vddc_based_on_leakage_params(struct amdgpu_device *adev,
