On 13/05/2020 17:41, Pablo Neira Ayuso wrote: > Hi, > > This patchset fixes the indirect flow_block support for the tc CT action > offload. Please, note that this batch is probably slightly large for the > net tree, however, I could not find a simple incremental fix. > > = The problem > > The nf_flow_table_indr_block_cb() function provides the tunnel netdevice > and the indirect flow_block driver callback. From this tunnel netdevice, > it is not possible to obtain the tc CT flow_block. Note that tc qdisc > and netfilter backtrack from the tunnel netdevice to the tc block / > netfilter chain to reach the flow_block object. This allows them to > clean up the hardware offload rules if the tunnel device is removed. > > <snip> > > = About this patchset > > This patchset aims to address the existing TC CT problem while > simplifying the indirect flow_block infrastructure. Saving 300 LoC in > the flow_offload core and the drivers. This might be a dumb question, but: what is the actual bug being fixed, that makes this patch series needed on net rather than net-next? >From your description it sounds like a good and useful cleanup/refactor, but nonetheless still a clean-up, appropriate for net-next. -ed
