On Tue, Apr 21, 2020 at 01:15:07AM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@xxxxxxxxxx>
>
> This resolves compiler warnings:
>
> extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:89:32: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> printf(" --ulog-nlgroup %d", ffs(loginfo->nl_group));
> ^
> extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:105:9: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> ffs(loginfo->nl_group));
> ^
>
> Test: builds with less warnings
For the record, what compiler is triggering this? Or you use different
-W options there?
I don't see these with gcc 9.3 here.
> Signed-off-by: Maciej Żenczykowski <maze@xxxxxxxxxx>
> ---
> extensions/libipt_ULOG.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/extensions/libipt_ULOG.c b/extensions/libipt_ULOG.c
> index fafb220b..5163eea3 100644
> --- a/extensions/libipt_ULOG.c
> +++ b/extensions/libipt_ULOG.c
> @@ -11,6 +11,7 @@
> */
> #include <stdio.h>
> #include <string.h>
> +#include <strings.h>
> #include <xtables.h>
> /* For 64bit kernel / 32bit userspace */
> #include <linux/netfilter_ipv4/ipt_ULOG.h>
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>
