Hillf Danton <hdanton@xxxxxxxx> wrote: > In case of failure to register NFPROTO_IPV4, unregister NFPROTO_IPV6 > instead of ops->pf (== NFPROTO_INET). > > --- a/net/netfilter/nf_nat_proto.c > +++ b/net/netfilter/nf_nat_proto.c > @@ -1022,8 +1022,8 @@ int nf_nat_inet_register_fn(struct net * > ret = nf_nat_register_fn(net, NFPROTO_IPV4, ops, nf_nat_ipv4_ops, > ARRAY_SIZE(nf_nat_ipv4_ops)); > if (ret) > - nf_nat_ipv6_unregister_fn(net, ops); > - > + nf_nat_unregister_fn(net, NFPROTO_IPV6, ops, > + ARRAY_SIZE(nf_nat_ipv6_ops)); > return ret; > } > EXPORT_SYMBOL_GPL(nf_nat_inet_register_fn); Yes. Please make a formal patch submission to netfilter-devel@, including you signed-off-by, the Reported-by tag from syzbot and a 'Fixes' tag for the buggy commit. Thank you.
