Re: [PATCH] libnetfilter_conntrack.pc.in: add LIBMNL_LIBS to Libs.Private

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 12, 2020 at 02:18:41PM +0200, Fabrice Fontaine wrote:
> Since version 1.0.8 and commit
> c1c0f16c1fedb46547c2e104beeaaeac5933b214, libnetfilter_conntrack depends
> on libmnl so add it to Libs.Private.
> 
> Otherwise, applications such as dnsmasq will fail to link on:
> 
> /home/buildroot/autobuild/instance-0/output-1/host/bin/arm-linux-gcc -Wl,-elf2flt -static -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o radv.o slaac.o auth.o ipset.o domain.o dnssec.o blockdata.o tables.o loop.o inotify.o poll.o rrfilter.o edns0.o arp.o crypto.o dump.o ubus.o metrics.o -L/home/buildroot/autobuild/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib -lnetfilter_conntrack -L/home/buildroot/autobuild/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib -lnfnetlink
> /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: /home/buildroot/autobuild/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib/libnetfilter_conntrack.a(api.o): in function `nfct_fill_hdr.constprop.4':
> api.c:(.text+0x34): undefined reference to `mnl_nlmsg_put_header'

Applied, thanks.

I think:

* libnetfilter_acct
* libnetfilter_cthelper
* libnetfilter_cttimeout
* libnetfilter_log
* libnetfilter_queue

need a similar fix.

> Fixes:
>  - http://autobuild.buildroot.org/results/3fdc2cba20162eb86eaa5c49a056fb40fb18a392
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
> ---
>  libnetfilter_conntrack.pc.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libnetfilter_conntrack.pc.in b/libnetfilter_conntrack.pc.in
> index 857f993..fbd7132 100644
> --- a/libnetfilter_conntrack.pc.in
> +++ b/libnetfilter_conntrack.pc.in
> @@ -12,5 +12,5 @@ Version: @VERSION@
>  Requires: libnfnetlink
>  Conflicts:
>  Libs: -L${libdir} -lnetfilter_conntrack
> -Libs.private: @LIBNFNETLINK_LIBS@
> +Libs.private: @LIBNFNETLINK_LIBS@ @LIBMNL_LIBS@
>  Cflags: -I${includedir}
> -- 
> 2.25.1
> 



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux