On Tue, Mar 31, 2020 at 08:14:17PM +0200, Jan Engelhardt wrote:
>
> On Tuesday 2020-03-31 18:35, Maciej Żenczykowski wrote:
> >Signed-off-by: Maciej Żenczykowski <maze@xxxxxxxxxx>
> >---
> > include/uapi/linux/netfilter/xt_IDLETIMER.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/include/uapi/linux/netfilter/xt_IDLETIMER.h b/include/uapi/linux/netfilter/xt_IDLETIMER.h
> >index 434e6506abaa..49ddcdc61c09 100644
> >--- a/include/uapi/linux/netfilter/xt_IDLETIMER.h
> >+++ b/include/uapi/linux/netfilter/xt_IDLETIMER.h
> >@@ -48,6 +48,7 @@ struct idletimer_tg_info_v1 {
> >
> > char label[MAX_IDLETIMER_LABEL_SIZE];
> >
> >+ __u8 send_nl_msg; /* unused: for compatibility with Android */
> > __u8 timer_type;
> >
> > /* for kernel module internal use only */
> >--
>
> This breaks the ABI for law-abiding Linux users (i.e. the GNU/Linux
> subgroup of it), which is equally terrible.
>
> You will have to introduce a IDLETIMER v2.
IIRC, IDLETIMER v1 is in net-next, scheduled for 5.7-rc, there is no
release for this code yet.
