Re: [PATCH net] net: Fix CONFIG_NET_CLS_ACT=n and CONFIG_NFT_FWD_NETDEV={y,m} build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 13:47:18 +0100

> net/netfilter/nft_fwd_netdev.c: In function ʽnft_fwd_netdev_evalʼ:
>     net/netfilter/nft_fwd_netdev.c:32:10: error: ʽstruct sk_buffʼ has no member named ʽtc_redirectedʼ
>       pkt->skb->tc_redirected = 1;
>               ^~
>     net/netfilter/nft_fwd_netdev.c:33:10: error: ʽstruct sk_buffʼ has no member named ʽtc_from_ingressʼ
>       pkt->skb->tc_from_ingress = 1;
>               ^~
> 
> To avoid a direct dependency with tc actions from netfilter, wrap the
> redirect bits around CONFIG_NET_REDIRECT and move helpers to
> include/linux/skbuff.h. Turn on this toggle from the ifb driver, the
> only existing client of these bits in the tree.
> 
> This patch adds skb_set_redirected() that sets on the redirected bit
> on the skbuff, it specifies if the packet was redirect from ingress
> and resets the timestamp (timestamp reset was originally missing in the
> netfilter bugfix).
> 
> Fixes: bcfabee1afd99484 ("netfilter: nft_fwd_netdev: allow to redirect to ifb via ingress")
> Reported-by: noreply@xxxxxxxxxxxxxx
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Applied, thanks.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux