On 2020-03-11, at 14:26:13 +0100, Pablo Neira Ayuso wrote: > Do you think it would be to keep back this one from the nf-next tree > until you evaluate an alternative way to extend nft_bitwise? > > commit 8d1f378a51fcf2f5e44e06ff726a91c885d248cc > Author: Jeremy Sowden <jeremy@xxxxxxxxxx> > Date: Mon Feb 24 12:49:31 2020 +0000 > > netfilter: bitwise: add support for passing mask and xor values in registers. If we do move away from converting all boolean op's to: d = (s & m) ^ x then it seems unlikely that the new attributes will be used. For me, it depends whether you rebase nf-next. I'm guessing not. In that case, I probably wouldn't bother reverting the patch now, since it's not big or invasive, and it wouldn't much matter if it went into 5.6 and got removed in a later patch-set. J.
Attachment:
signature.asc
Description: PGP signature