Hi again Florian, On Mon, Feb 24, 2020 at 11:16:48AM +0100, Florian Westphal wrote: > Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote: > > Can I suggest: > > > > > + * example because this is an incoming packet and the NIC does not > > > + * perform checksum validation at hardware level. > > - > + * See nfq_set_queue_flags() documentation for more information. > > > + * > > > + * \return the skbinfo value > > + > + * \sa __nfq_set_queue_flags__(3) > > > + */ > > > +EXPORT_SYMBOL > > > > I think this will look better, especially on the man page. > > Its does, thanks. I've made this change in my local tree. Sorry to do this to you, but would you mind changing line ~56 in fixmanpages.sh from "function add2group" to "function add2group" please?. I.e. remove 2 unnecessary spaces. This will then match commit cbe9959921 (src: expose nfq_nlmsg_put) Cheers ... Duncan.
