Having a single point makes refactoring easier. Signed-off-by: Laurent Fasnacht <fasnacht@xxxxxxxxxxxxx> --- src/scanner.l | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/scanner.l b/src/scanner.l index 2016acd5..37b01639 100644 --- a/src/scanner.l +++ b/src/scanner.l @@ -670,6 +670,7 @@ static void scanner_push_indesc(struct parser_state *state, { state->indescs[state->indesc_idx] = indesc; state->indesc = state->indescs[state->indesc_idx++]; + list_add_tail(&indesc->list, &state->indesc_list); } static void scanner_pop_indesc(struct parser_state *state) @@ -710,7 +711,6 @@ static void scanner_push_file(struct nft_ctx *nft, void *scanner, init_pos(indesc); scanner_push_indesc(state, indesc); - list_add_tail(&indesc->list, &state->indesc_list); } static int include_file(struct nft_ctx *nft, void *scanner, @@ -907,15 +907,14 @@ void scanner_push_buffer(void *scanner, const struct input_descriptor *indesc, { struct parser_state *state = yyget_extra(scanner); YY_BUFFER_STATE b; + struct input_descriptor *new_indesc; - state->indesc = xzalloc(sizeof(struct input_descriptor)); - state->indescs[state->indesc_idx] = state->indesc; - state->indesc_idx++; + new_indesc = xzalloc(sizeof(struct input_descriptor)); - memcpy(state->indesc, indesc, sizeof(*state->indesc)); - state->indesc->data = buffer; - state->indesc->name = NULL; - list_add_tail(&state->indesc->list, &state->indesc_list); + memcpy(new_indesc, indesc, sizeof(*new_indesc)); + new_indesc->data = buffer; + new_indesc->name = NULL; + scanner_push_indesc(state, new_indesc); b = yy_scan_string(buffer, scanner); assert(b != NULL); -- 2.20.1