Hi Pablo, On Sat, Feb 01, 2020 at 05:21:27PM +1100, Duncan Roe wrote: > Functions pktb_alloc_data, pktb_make and pktb_make_data are defined. > The pktb_make pair are syggested as replacements for the pktb_alloc (now) pair > because they are always faster. > > - Add prototypes to include/libnetfilter_queue/pktbuff.h > - Add pktb_alloc_data much as per Pablo's email of Wed, 8 Jan 2020 > speedup: point to packet data in netlink receive buffer rather than copy to > area immediately following pktb struct > - Add pktb_make much like pktb_usebuf proposed on 10 Dec 2019 > 2 sppedups: 1. Use an existing buffer rather than calloc and (later) free one. > 2. Only zero struct and extra parts of pktb - the rest is > overwritten by copy (calloc has to zero the lot). > - Add pktb_make_data > 3 speedups: All of the above > - Document the new functions > - Move pktb_alloc and pktb_alloc_data into the "other functions" group since > they are slower than the "make" equivalent functions > > Signed-off-by: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> [...] Did you notice this? I guess it should have been v3 really. I'd really appreciate some feedback soon, if you or whoever could find the time. Cheers ... Duncan.
