Re: [PATCH nft v3 0/9] bitwise shift support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 19, 2020 at 10:57:01PM +0000, Jeremy Sowden wrote:
> The kernel supports bitwise shift operations.  This patch-set adds the
> support to nft.  There are a few preliminary housekeeping patches.

Actually, this batch goes in the direction of adding the basic
lshift/right support.

# nft --debug=netlink add rule x y tcp dport set tcp dport lshift 1
ip x y 
  [ meta load l4proto => reg 1 ]
  [ cmp eq reg 1 0x00000006 ]
  [ payload load 2b @ transport header + 2 => reg 1 ]
  [ byteorder reg 1 = ntoh(reg 1, 2, 2) ]
  [ bitwise reg 1 = ( reg 1 << 0x00000001 ) ]
  [ payload write reg 1 => 2b @ transport header + 2 csum_type 1 csum_off 16 csum_flags 0x0 ]

I'm applying patches 1, 2, 3, 4, 7 and 8.

Regarding patch 5, it would be good to restore the parens when
listing.

Patch 6, I guess it will break something else. Did you run tests/py to
check this?

Patch 9, I'm skipping until 5 and 6 are sorted out.

Thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux