Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > + list_for_each_entry(req, &net->nft.module_list, list) { > + if (!strcmp(req->module, module_name) && req->done) > + return 0; > + } If the module is already on this list, why does it need to be added a second time? Other than that I like this idea as it avoids the entire "drop transaction mutex while inside a transaction" mess.