On Mon, Jan 20, 2020 at 05:25:39PM +0100, Phil Sutter wrote: > Covscan complained about potential deref of NULL 'lei' pointer, > Interestingly this can't happen as the relevant goto leading to that > (in line 260) sits in code checking conflicts between new intervals and > since those are sorted upon insertion, only the lower boundary may > conflict (or both, but that's covered before). > > Given the needed investigation to proof covscan wrong and the actually > wrong (but impossible) code, better fix this as if element ordering was > arbitrary to avoid surprises if at some point it really becomes that. > > Fixes: 4d6ad0f310d6c ("segtree: check for overlapping elements at insertion") Not fixing anything. Tell them to fix covscan :-)