Re: [PATCH nf-next v3 5/9] nf_tables: Add set type for arbitrary concatenation of ranges

[Stefano Brivio <sbrivio@xxxxxxxxxx>]

On Tue, 21 Jan 2020 00:13:17 +0800
kbuild test robot <lkp@xxxxxxxxx> wrote:

> All errors (new ones prefixed by >>):
> 
> >> ERROR: "__udivdi3" [net/netfilter/nf_tables_set.ko] undefined!
> >> ERROR: "__divdi3" [net/netfilter/nf_tables_set.ko] undefined!  

Right, this needs:

diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c
index 5946fba8eb84..f0cb1e13af50 100644
--- a/net/netfilter/nft_set_pipapo.c
+++ b/net/netfilter/nft_set_pipapo.c
@@ -1925,7 +1925,7 @@ static bool nft_pipapo_estimate(const struct nft_set_desc *desc, u32 features,
 
        /* Rules in lookup and mapping tables are needed for each entry */
        est->size = desc->size * entry_size;
-       if (est->size && est->size / desc->size != entry_size)
+       if (est->size && div_u64(est->size, desc->size) != entry_size)
                return false;
 
        est->size += sizeof(struct nft_pipapo) +

I will change that in the next version.

-- 
Stefano