Re: [PATCH nf-next] netfilter: nft_bitwise: correct uapi header comment.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 01, 2020 at 01:41:32PM +0000, Jeremy Sowden wrote:
> The comment documenting how bitwise expressions work includes a table
> which summarizes the mask and xor arguments combined to express the
> supported boolean operations.  However, the row for OR:
> 
>  mask    xor
>  0       x
> 
> is incorrect.
> 
>   dreg = (sreg & 0) ^ x
> 
> is not equivalent to:
> 
>   dreg = sreg | x
> 
> What the code actually does is:
> 
>   dreg = (sreg & ~x) ^ x
> 
> Update the documentation to match.

Applied, thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux