Re: [nft PATCH 1/2] tests: shell: Search diff tool once and for all

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 14, 2020 at 05:46:29PM +0100, Phil Sutter wrote:
> Instead of calling 'which diff' over and over again, just detect the
> tool's presence in run-tests.sh and pass $DIFF to each testcase just
> like with nft binary.
> 
> Fall back to using 'true' command to avoid the need for any conditional
> calling in test cases.
> 
> While being at it, unify potential diff calls so that a string
> comparison in shell happens irrespective of diff presence.
> 
> Signed-off-by: Phil Sutter <phil@xxxxxx>

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux