On Fri, Jan 10, 2020 at 03:09:25PM +1100, Duncan Roe wrote: > In struct pkt_buff: > - We only ever needed any 2 of len, data and tail. You can remove ->tail. > This has caused bugs in the past, e.g. commit 8a4316f31. > Delete len, and where the value of pktb->len was required, > use new PKTB_LEN macro. I would leave pktb->len in please, it keeps things simple. Otherwise, I would suggest to remove pktb->data_len, keep pktb->len in place and reallocate the data buffer only in case of mangling. > - head and data always had the same value. > head was in the minority, so replace with data where it was used. This item above also looks fine. Probably you can split this in several patches, one for each item. Thanks.
