On Tue, Dec 17, 2019 at 10:39:45PM +0100, Pablo Neira Ayuso wrote: > On Sat, Dec 14, 2019 at 09:26:31AM +0100, Simon Horman wrote: > > On Fri, Dec 13, 2019 at 04:53:06PM +0800, Xin Long wrote: > > > ERSPAN_VERSION is an attribute parsed in kernel side, nla_policy > > > type should be added for it, like other attributes. > > > > > > Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support") > > > > Is this really a fix? > > I think so. Netlink attribute validation for > NFTA_TUNNEL_KEY_ERSPAN_VERSION is missing. Ok, I accept that reasoning.