Re: [nf PATCH] netfilter: nft_tproxy: Fix port selector on Big Endian

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Dec 18, 2019 at 01:03:15AM +0100, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > On Big Endian architectures, u16 port value was extracted from the wrong
> > parts of u32 sreg_port, just like commit 10596608c4d62 ("netfilter:
> > nf_tables: fix mismatch in big-endian system") describes.
> 
> I was about to debug this today, thanks for debugging/fixing this.

With that BE machine at hand, I quickly gave nftables testsuite a try -
results are a bit concerning: The mere fact that netlink debug output
for these immediates differs between BE and LE indicates we don't
seriously test on BE.

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux