Re: forwarded bridged packets enqueuing is broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marco Oliverio <marco.oliverio@xxxxxxxxxx> wrote:
> We cannot enqueue userspace bridged forwarded packets (neither in the
> forward chain nor in the postrouting one):

[..]

> AFAIU forwarded bridge packets have a null dst entry in the first
> place, as they don't enter the ip stack, so skb_dst_force() returns
> false. The very same commit suggested to check skb_dst() before
> skb_dst_force(), doing that indeed fix the issue for us:
> 
> modified   net/netfilter/nf_queue.c
> @@ -174,7 +174,7 @@ static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,
>  		goto err;
>  	}
>  
> -	if (!skb_dst_force(skb) && state->hook != NF_INET_PRE_ROUTING) {
> +	if (skb_dst(skb) && !skb_dst_force(skb)) {

Looks fine to me, please submit this formally.  Thanks!



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux