Hi pablo, Any comments about this patch? BR wenxu On 11/13/2019 12:21 PM, wenxu@xxxxxxxxx wrote: > From: wenxu <wenxu@xxxxxxxxx> > > It should check the NETDEV_UNREGISTER in nft_offload_netdev_event > > Fixes: 06d392cbe3db ("netfilter: nf_tables_offload: remove rules when the device unregisters") > Signed-off-by: wenxu <wenxu@xxxxxxxxx> > --- > net/netfilter/nf_tables_offload.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c > index e25dab8..b002832 100644 > --- a/net/netfilter/nf_tables_offload.c > +++ b/net/netfilter/nf_tables_offload.c > @@ -446,6 +446,9 @@ static int nft_offload_netdev_event(struct notifier_block *this, > struct net *net = dev_net(dev); > struct nft_chain *chain; > > + if (event != NETDEV_UNREGISTER) > + return 0; > + > mutex_lock(&net->nft.commit_mutex); > chain = __nft_offload_get_chain(dev); > if (chain)