On 2019-11-25, at 22:30:43 +0100, Pablo Neira Ayuso wrote: > On Mon, Nov 25, 2019 at 08:54:50PM +0000, Jeremy Sowden wrote: > > The description of the set statement asserts that the set must have > > been created with the "dynamic" flag. However, this is not in fact > > the case, and the assertion is contradicted by the following > > example, in which the set is created with just the "timeout" flag > > (which suffices to ensure that the kernel will create a set which > > can be updated). Remove the assertion. > > The timeout implies dynamic. > > Without the timeout flag, you need the dynamic flag. > > Do you want to keep supporting this scenario or probably this should > disallow set updates from the packet path with no timeout. Having gone back and had another look at the code, I see that I missed (or forgot) the fact one can include stateful expressions in set state- ments, and without the "dnyamic" flag these will not work. Thus drop- ping the reference to it from the documentation is the wrong thing to do. I'll redo the patch. J.
Attachment:
signature.asc
Description: PGP signature
