Re: [iptables PATCH v4 00/12] Implement among match support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 21, 2019 at 06:36:35PM +0100, Phil Sutter wrote:
> Changes since v3:
> - Rebase onto current master.
> - Whitespace fixup in patch 7.
> 
> Changes since v2:
> - Rebased onto current master branch. With cache levels being upstream,
>   no dependencies on unfinished work remains.
> - Integrate sets caching into cache level infrastructure.
> - Fixed temporary build breakage within series.
> - Larger review of last patch containing the actual among match
>   extension.
> 
> Changes since v1:
> - Rebased onto my performance improvements patch series.
> - Aligned set caching routines with changes in above series.
> - Fixed patch ordering so builds are not broken intermittently.
> - Replaced magic numbers by defines or offsetof() statements. Note that
>   I did not move any defines into libnftnl; the remaining ones are for
>   values in sets' key_type attribute which neither libnftnl nor kernel
>   care about. Setting that is merely for compatibility with nft tool.
> 
> This series ultimately adds among match support to ebtables-nft. The
> implementation merely shares the user interface with legacy one,
> internally the code is distinct: libebt_among.c does not make use of the
> wormhash data structure but a much simpler one for "temporary" storage
> of data until being converted into an anonymous set and associated
> lookup expression.
> 
> Patches 1 to 5 implement required changes and are rather boring by
> themselves: When converting an nftnl rule to iptables command state,
> cache access is required (to lookup set references).
> 
> Patch 6 simplifies things a bit with the above in place.
> 
> Patches 7 to 11 implement anonymous set support.
> 
> Patch 12 then adds the actual among match implementation for
> ebtables-nft.

For this series:

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Thanks Phil.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux