Re: [PATCH nf-next 8/8] nft_set_pipapo: Introduce AVX2-based lookup implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> Probably, at some point we can start exposing knobs, but I'd rather
> see a bit more discussions on how to provide a good autotuning. By
> exposing all knobs, then such discussion might not ever happen?

My remarks were not aimed at exposing knobs but to provide some
debugging aid.

Say e.g. there is a bug in the avx implementation that isn't present
in the C version, or vice versa.  Or in rhashtable but not hashtable.

Right now it requires some guesswork to figure out what set backend is
actually used for @myset, and it might make things easier for debugging
if one could query the kernel for some information wrt. what set backend
is used.  I would try to avoid to expose anything that can't be ripped
out again, so e.g. names or even just %pF of ->lookup() would perhaps be
enough.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux