Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote: > Deprecated nfq_set_queue_flags documents flag NFQA_CFG_F_FAIL_OPEN for kernel to > accept packets if the kernel queue gets full. > > Does this still work with libmnl? Yes. > I'm thinking we need a new "Library Setup > [CURRENT]" section to document available flags (including e.g. NFQA_CFG_F_GSO > that examples/nf-queue.c uses). Makes sense, thanks. > Maybe we need Attribute helper functions as well? (documentation *and* new > code). If you think it makes it easier, sure, why not. But it would be something like this: void nfq_nlmsg_cfg_put_flags(struct nlmsghdr *nlh, uint32_t flags) { mnl_attr_put_u32(nlh, NFQA_CFG_FLAGS, htonl(flags)); mnl_attr_put_u32(nlh, NFQA_CFG_MASK, htonl(flags)); } I'm not sure that warrants a library helper.