Re: [nft PATCH] meta: Rewrite hour_type_print()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 12, 2019 at 07:59:31PM +0100, Phil Sutter wrote:
> There was no point in this recursively called __hour_type_print_r() at
> all, it takes only four lines of code to split the number of seconds
> into hours, minutes and seconds.
> 
> While being at it, inverse the conditional to reduce indenting for the
> largest part of the function's body. Also introduce SECONDS_PER_DAY
> macro to avoid magic numbers.
> 
> Fixes: f8f32deda31df ("meta: Introduce new conditions 'time', 'day' and 'hour'")
> Signed-off-by: Phil Sutter <phil@xxxxxx>

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux