On 11/7/19 12:45 PM, Phil Sutter wrote: > These are not meant to be executed as is but instead loaded via > 'nft -f' - all-in-one.nft even points this out in header comment. > While being at it, drop two spelling mistakes found along the way. > > Consequently remove executable bits - being registered in automake as > dist_pkgsysconf_DATA, they're changed to 644 upon installation anyway. > > Also there is obviously no need for replacement of nft binary path > anymore, drop that bit from Makefile.am. If you drop the shebang, the shell may not know how to execute these files. Why not executing them with the python interpreter instead of `nft -f`? As pablo commented, the intention was to allow simple use cases like: root@server:~# ./load-my-ruleset.nft This use case would still be allowed after this patch but it would be a little less obvious (less examples). So I'm not sure about ACK'ing this patch.
