Hi Pablo, I love your patch! Yet something to improve: [auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_tables_offload-pass-extack-to-nft_flow_cls_offload_setup/20191103-115127 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): net/netfilter/nf_tables_offload.c: In function 'nft_flow_offload_unbind': >> net/netfilter/nf_tables_offload.c:218:10: error: incompatible type for argument 1 of 'memset' memset(extack, 0, sizeof(extack)); ^~~~~~ In file included from arch/x86/include/asm/string.h:5:0, from include/linux/string.h:20, from include/linux/bitmap.h:9, from include/linux/cpumask.h:12, from arch/x86/include/asm/cpumask.h:5, from arch/x86/include/asm/msr.h:11, from arch/x86/include/asm/processor.h:21, from arch/x86/include/asm/cpufeature.h:5, from arch/x86/include/asm/thread_info.h:53, from include/linux/thread_info.h:38, from arch/x86/include/asm/preempt.h:7, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:10, from net/netfilter/nf_tables_offload.c:3: arch/x86/include/asm/string_64.h:18:7: note: expected 'void *' but argument is of type 'struct netlink_ext_ack' void *memset(void *s, int c, size_t n); ^~~~~~ vim +/memset +218 net/netfilter/nf_tables_offload.c 206 207 static int nft_flow_offload_unbind(struct flow_block_offload *bo, 208 struct nft_base_chain *basechain) 209 { 210 struct flow_block_cb *block_cb, *next; 211 struct flow_cls_offload cls_flow; 212 struct netlink_ext_ack extack; 213 struct nft_chain *chain; 214 struct nft_rule *rule; 215 216 chain = &basechain->chain; 217 list_for_each_entry(rule, &chain->rules, list) { > 218 memset(extack, 0, sizeof(extack)); 219 nft_flow_cls_offload_setup(&cls_flow, basechain, rule, NULL, 220 &extack, FLOW_CLS_DESTROY); 221 nft_setup_cb_call(TC_SETUP_CLSFLOWER, &cls_flow, &bo->cb_list); 222 } 223 224 list_for_each_entry_safe(block_cb, next, &bo->cb_list, list) { 225 list_del(&block_cb->list); 226 flow_block_cb_free(block_cb); 227 } 228 229 return 0; 230 } 231 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
