On Thu, Oct 31, 2019 at 09:37:07AM +0100, Marvin Schmidt wrote: > clang does not allow attribute declarations after definitions: > > flowtable.c:41:1: warning: attribute declaration must precede definition [-Wignored-attributes] > EXPORT_SYMBOL(nftnl_flowtable_alloc); > ^ > ../include/utils.h:13:41: note: expanded from macro 'EXPORT_SYMBOL' > # define EXPORT_SYMBOL(x) typeof(x) (x) __visible; > ^ > ../include/utils.h:12:35: note: expanded from macro '__visible' > # define __visible __attribute__((visibility("default"))) > ^ > flowtable.c:37:25: note: previous definition is here > struct nftnl_flowtable *nftnl_flowtable_alloc(void) > > Move attribute declarations before the symbol definitions just like > it's done in other source files Applied, thanks.